[WIP] Enable Elmish apps in React components instead of full programs #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I've mentioned in that discussion, I'm in the Separate Library camp - conceptually, this looks more like extension to React than extension to Elmish (which is what this package is for). Even if it's just 1 F# file, one could import it as github dependency with paket. |
|
Same here, I think it's place is in a separate library. |
|
Ups, sorry @et1975 missed your comment in the other discussion 😅 Ok, I'll close this one and we can publish a separate library if necessary 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fable.React includes a way to create React components as if they were mini-Elmish apps but I think not many people uses it.
There's a PR that's been open for a long time to make this ability more powerful by adding Elmish commands. However, I've been reluctant to merge it because it adds a dependency to Fable.Elmish and I'd like to keep those packages independent.
If we want to create mini Elmish apps using React components instead of full programs (to make them composable), maybe this should be a feature of this package instead? What do you think? @et1975 @MangelMaxime @vbfox